CORE-4837: Replaced dashes with underscores. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate isValidEncodedValue function to pass values with dash.
…or all heatmap EV
…ikeTrackedParser.java
benedikt-brandtner-bikemap
requested changes
Jun 6, 2023
There was a problem hiding this comment.
Hey awesome work implementing the parsing of Weight-Tags from the Way :)
I've found a Way to fetch the Tag-Configuration from environment variables which also enables us to remove all the the EncodedValue classes except for BMWeight and all the parser classes except form BMWeightParser.
If those changes make sense to you it would enable us to not have to implement additional changes when we move to production and als make maintenance easier in the future.
Greets
core/src/main/java/com/graphhopper/routing/ev/DefaultEncodedValueFactory.java
Show resolved
Hide resolved
core/src/main/java/com/graphhopper/routing/ev/DefaultEncodedValueFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/graphhopper/routing/util/EncodingManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/graphhopper/routing/util/parsers/BMWeightParser.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/graphhopper/routing/util/parsers/DefaultTagParserFactory.java
Show resolved
Hide resolved
core/src/main/java/com/graphhopper/routing/util/parsers/DefaultTagParserFactory.java
Outdated
Show resolved
Hide resolved
benedikt-brandtner-bikemap
approved these changes
Jun 7, 2023
Already tag the new head |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Parsers for all bmweight tags. Replaced dashes with underscores.