Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix loading-state container reference in loading-states extension #2478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jozefrebjak
Copy link

Description

Applied fix as in 695fd8a for loading-states extension.

Corresponding issue: #2450

Testing

I tested it locally on MacOS M1 Sonoma with Safari 17.4.1

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@andryyy
Copy link

andryyy commented Apr 12, 2024

Let me do my part as a good user:

Can this be merged? Why hasn’t this been merged yet? Is the project dead?
Is there a fork? Why are the devs not responding?

Thanks for the fix. :)

@Telroshan Telroshan added the bug Something isn't working label Apr 14, 2024
@jozefrebjak
Copy link
Author

Dear @1cg ,

I would greatly appreciate it if you could review the current PR. Additionally, there are several other PRs specifically addressing issues related to Safari.

Thank you in advance for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants