Fixes issue 1537 - OOB does not escape query selector #2319
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change alters how the oobSwap function builds the query selector string. Rather than simply prefixing it with a
#
it uses the'[id="raw_id"]'
format. Whereraw_id
is the value obtained fromgetRawAttribute(oobElement, "id")
Ideally this could be done more cleanly with template literals (backtick strings) - but as I understand it you want to support IE11.
This fix allows the call querySelectorAll to return the nodelist of all elements with the ids such as "foo-/bar" - without getting "Failed to execute 'querySelectorAll' on 'Document': '#foo-/bar' is not a valid selector, and whilst not limiting the selection to the first matching id in the document.
Corresponding issue:
#1537
Testing
I ran the htmx.js test suite Version: 1.9.10 and got 0 failures
I also manually tested ids such as "foo-/bar" and it all seems to be working as expected.
Further to this I've added test cases for
'handles elements with IDs containing special characters properly'
and
'handles one swap into multiple elements with the same ID properly'
And re- ran the htmx.js test suite Version: 1.9.10 and got 0 failures
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded