use wildcard (*) to match "revealed" trigger when scrolling #2237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2233, using wildcard to match "revealed" trigger when collecting elements to execute
maybeReveal
on while scrolling allows using more events in the same hx-trigger attribute (i.e. click, mouseenter, custom events, etc)A minimal example to reproduce the bug is included in the original issue.
Corresponding issue: #2233
Testing
The only way to test this is to have an element with
hx-trigger="revealed, anyOtherEvent"
below the fold (so that the initialmaybeReveal
function would not trigger the request)I've updated
scroll-test-eventHandler.html
manual test to include 3 cases (at the very bottom), when the reveal event appears first, when it's last and when it's in the middle. All of them working after applying the fix.Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded