Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Handlebars implementation #2199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RayyanNafees
Copy link

@RayyanNafees RayyanNafees commented Jan 16, 2024

Description

Handlebars says itself to be "Mustache compatible" on their website but its implementation with HTMX client-side-template extension is slightly different and breaks when migrating to Handlebars from Mustache

I've added the Different implementation from mustache, needed to be followed when using handlebars

Significantly two explicit changes are needed

  1. Use the CDN upkg.com /handlebars@latest/dist/handlebars.min.js instead of /handlebars@latest
  2. Use {#each this} for looping instead of {#each data} or {#data} inspired from mustache example

Corresponding issue:

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

Handlebars says itself to be "Mustache compatible" on their [website](https://handlebarsjs.com) but its implementation with HTMX `client-side-template` extension is slightly different and breaks when migrating to Handlebars from Mustache

I've added the Different implementation from mustache, needed to be followed when using handlebars
@Telroshan Telroshan added the documentation Improvements or additions to documentation label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants