Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2056 Updated the tracking of changed values to record the value against th… #2063

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mikeedwards83
Copy link

@mikeedwards83 mikeedwards83 commented Dec 1, 2023

Description

Updated the tracking of changed values to record the value against the source element instead of the target element.
This allows multiple source elements to listen to a single target for a change.

Corresponding issue:

#2056

Testing

Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.

I tested this against the example in the issue. With the fix both triggers were fired, not just the one.

I also performed a couple of tests against other HTMX components I had written to check I hadn't broken anything else. This wasn't extensive testing.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

…e source element instead of the target element.

This allows multiple source elements to listen to a single target for a change.
@mikeedwards83 mikeedwards83 changed the title Updated the tracking of changed values to record the value against th… #2056 Updated the tracking of changed values to record the value against th… Dec 1, 2023
@Telroshan Telroshan added the bug Something isn't working label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants