-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use generateStaticParams to pregenerate some routes #1886
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
const brands = await getBrands(); | ||
|
||
return routing.locales.map((locale) => { | ||
return removeEdgesAndNodes(brands).map((brand) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I have been thinking about recently when migrating the account pages. I think we should probably have the pattern of removing the edges and nodes closer to the boundary, in this case inside getBrands
. This way consumers don't need to worry about it and can focus on just massaging a normalized payload into what is needed for the page.
ced9e8b
to
41aea38
Compare
|
41aea38
to
e3c2a7e
Compare
e3c2a7e
to
fc9ccea
Compare
fc9ccea
to
34ecbcc
Compare
Closing PR because it is not providing value as expected. |
What/Why?
Testing