fix: product-carousel and product-list now sort properly, included append checkbox control #1646
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
|
| if (product?.entityId) { | ||
| return product.entityId.label; | ||
| } | ||
|
|
||
| return product?.title || 'Product Title'; |
There was a problem hiding this comment.
Interesting. So entity IDs have labels?
Also, why not do this?
return product?.entityId.label ?? product?.title ?? 'Product Title'| @@ -116,7 +141,7 @@ runtime.registerComponent( | |||
| } | |||
|
|
|||
| return { | |||
| id: title ?? '', | |||
| id: index.toString(), | |||
There was a problem hiding this comment.
We should use a stable identifier here instead of the index
There was a problem hiding this comment.
Should we be forcing users to enter an ID or something? Alan was saying using index is the most intuitive way outside of entering one in manually. What about ${title}-${index}?
There was a problem hiding this comment.
Don't we have the ID of the product?
…ility to append or prepend
drewpledger
force-pushed
the
dp/product-lists-sort
branch
from
befabf9 to
09cb2d4
Compare
products-list.makeswift.tsxCleanShot.2024-11-15.at.16.10.14.mp4
products-carousel.makeswift.tsxCleanShot.2024-11-15.at.16.11.32.mp4