-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #178
base: develop
Are you sure you want to change the base?
Spelling #178
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw, I've been maintaining this for a while now, it gets conflicts constantly. They're generally fairly easy to resolve, but there isn't much point in me doing another round until a reviewer looks things over describes how they'd want to approach it.
I'm not done annotating this PR, but the GitHub PR viewer is really slow, so I've marked >400 of the files as viewed.
If I were reviewing this, I'd probably just pull in x commits into a PR in a personal fork and review them and then make/ask for changes and merge.
GitHub doesn't like PRs with >250 commits, and it isn't really a fan of PRs with >1000 files.
As PRs go, this is on the small side, I've had PRs with 1000 commits. In general maintainers suggest a split, e.g. by directory or file type. Here I don't think either would help as they're are basically two directories and two file types.
- fixed: move `packaeg-lock.json` inside docker container. | ||
- fixed: move `package-lock.json` inside docker container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some projects don't like changing their changelogs, but I'd argue it's worth it in this case.
@@ -86,7 +86,7 @@ All notable changes to Bigcapital server-side will be in this file. | |||
|
|||
## [0.8.3] - 06-04-2023 | |||
|
|||
`@bigcaptial/monorepo` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brand...
"An account that holds valuation of products or goods that availiable for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.", | ||
"An account that holds valuation of products or goods that available for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some projects don't like changing translation files. I can easily omit them...
"An account that holds valuation of products or goods that availiable for sale.": "An account that holds valuation of products or goods that availiable for sale.", | ||
"An account that holds valuation of products or goods that available for sale.": "An account that holds valuation of products or goods that available for sale.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some projects don't like changing translation keys. I'm happy to drop such changes (or any other changes...)
tbody tr.blanace-due td { | ||
tbody tr.balance-due td { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a html class is used beyond the code of a repository, it probably shouldn't be changed, but if the code is self-contained, it makes sense to change it...
expecvt(res.body.errors).include.something.deep.equals({ | ||
expect(res.body.errors).include.something.deep.equals({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
* Detarmines whether the given root type equals the account type. | ||
* Determines whether the given root type equals the account type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is Determines
whereas the next one is Determine
, I'm not sure why there's a divergence...
* Detarmine whether the given parent type equals the account type. | ||
* Determine whether the given parent type equals the account type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is Determine
whereas the previous one is Determines
, I'm not sure why there's a divergence...
*Transformes the account transaction to to cashflow transaction node. | ||
*Transforms the account transaction to to cashflow transaction node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there really should be a space after the *
, but I'm not making changes like that...
@@ -39,7 +39,7 @@ export default class CashflowAccountTransactionReport extends FinancialSheet { | |||
} | |||
|
|||
/** | |||
*Transformes the account transaction to to cashflow transaction node. | |||
*Transforms the account transaction to to cashflow transaction node. | |||
* @param {IAccountTransaction} transaction | |||
* @returns {ICashflowAccountTransaction} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSDoc supports both @return
and @returns
, https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html#types, but it's probably best to use one of these two consistently and avoid using the other...
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/bigcapital/actions/runs/5390721361#summary-14591784959
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/bigcapital/actions/runs/5390722721#summary-14591789667