Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-default-export-warnings-on-import #164

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

suhaibaffan
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bigcapital-webapp ❌ Failed (Inspect) Jun 17, 2023 2:37am

@abouolia
Copy link
Contributor

abouolia commented Jun 19, 2023

First of all, I really appreciate your contribution, could you please explain why you changed from CJS to ESM exporting/exporting?, second thing, the pipelines are broken.

Again thanks for your contribution especially with early adopters like you.

@suhaibaffan
Copy link
Contributor Author

Sorry for the late reply!
I have mainly used esm to remove warnings and import in async manner.
I will look into the pipelines and try to fix it.
If you think this is not needed I will close this PR :).
I look forward for the success of this project.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants