Add env EXTERNAL_AUTH and replace checks for OPENID_CONNECT with checks for EXTERNAL_AUTH where applicable #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhatahmad
reviewed
Oct 26, 2023
| @@ -26,6 +26,7 @@ class EnvController < ApiController | |||
| def index | |||
| render_data data: { | |||
| OPENID_CONNECT: ENV['OPENID_CONNECT_ISSUER'].present?, | |||
There was a problem hiding this comment.
We can remove this now no?
There was a problem hiding this comment.
Currently it would be unused, yes. Not sure if there could be a future use for this though.
There was a problem hiding this comment.
I would remove it then if possible please
|
Great idea for this PR and definitely makes it easier for us to manage - thanks for your hard work |
|
Kudos, SonarCloud Quality Gate passed!
|
farhatahmad
approved these changes
Oct 30, 2023
SebastianAppDev
pushed a commit
to SebastianAppDev/greenlight
that referenced
this pull request
Dec 20, 2023
…ks for EXTERNAL_AUTH where applicable (bigbluebutton#5480) * add env EXTERNAL_AUTH and replace env OPENID_CONNECT with it where applicable * remove OPENID_CONNECT from envAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OIDC is currently the only implemented external authentication provider, in all the places where you would normally check for external auth usage there is instead a check for OIDC usage. This PR introduces a new env EXTERNAL_AUTH and replaces these checks with a check for EXTERNAL_AUTH. Also a few comments are left at places where additional providers would have to be "added".
This paves the way for addition of other external auth providers and, even if there are no plans to develop these from upstream side, makes it easier to develop and maintain extensions such as #5476 . Also, it will not require any additional effort to maintain the changes made in this PR and it does not change the current behavior of GL3.
If any changes have to be made to make this mergeable, I'm happy to work on them. Please let me know!