Makefile build: all Docker builds to be based on newly built hadoop-base image #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass tag/version of hadoop-base image forward to Docker builds of components (namenode, etc.) so that all newly built component images are based on the same hadoop-base image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "build" target in the Makefile uses the current git branch name as version tag for all newly built Docker images. However, the images of Hadoop components (namenode, etc.) are not based on the newly built "hadoop-base" image. Instead, the version of the hadoop-base image is hardwired in the Dockerfiles off the components. The Makefile should pass the tag/version of "hadoop-base" image forward to Docker builds of components, so that all newly built component images are based on the same "hadoop-base" image.