Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support raw public keys (RFC 7250) #208

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Support raw public keys (RFC 7250) #208

wants to merge 9 commits into from

Conversation

bifurcation
Copy link
Owner

Main components here:

  • Definition of the client_certificate_type and server_certificate_type extensions
  • Related negotiation logic
  • Generalization of certificate logic in the handshake to support both raw keys and certificates

@bifurcation bifurcation requested a review from ekr September 1, 2019 21:59
ekr
ekr requested changes Jun 13, 2021
View reviewed changes
Copy link
Collaborator

@ekr ekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is RFC 7250, not 7520.

Tests seem a bit thin.

client-state-machine.go Outdated Show resolved Hide resolved
client-state-machine.go Outdated Show resolved Hide resolved
client-state-machine.go Outdated Show resolved Hide resolved
client-state-machine.go Show resolved Hide resolved
client-state-machine.go Outdated Show resolved Hide resolved
extensions.go Show resolved Hide resolved
extensions.go Show resolved Hide resolved
server-state-machine.go Outdated Show resolved Hide resolved
server-state-machine.go Outdated Show resolved Hide resolved
server-state-machine.go Show resolved Hide resolved
upros
upros reviewed Jun 14, 2021
View reviewed changes
client-state-machine.go Outdated Show resolved Hide resolved
upros
upros reviewed Jun 14, 2021
View reviewed changes
client-state-machine.go Outdated Show resolved Hide resolved
upros
upros reviewed Jun 14, 2021
View reviewed changes
server-state-machine.go Outdated Show resolved Hide resolved
@bifurcation bifurcation changed the title Support raw public keys (RFC 7520) Support raw public keys (RFC 7250) Jun 16, 2021
@bifurcation
Copy link
Owner Author

@ekr This update is substantially cleaned up, should address your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upros upros upros left review comments

@ekr ekr ekr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bifurcation @ekr @upros