fix links, check circleci artifacts

[sappelhoff]

• closes add an markdown link checkcker config  #232
• discusses some of CircleCI artifacts appear to be broken -- switch to netlify? #230

I went for the "just fix the links" route. EDIT: and then I also updated the config, as suggested by @Remi-Gau

[sappelhoff]

@larsoner, I have a question about the circleci redirector app, which somehow has stopped working (see also #230), I think one can see it nicely in the current artifacts.

The artifacts are produced as expected, and when navigating via the circleci artifacts tab, clicking on individual html files works, e.g., this site

One gets the same site (as expected) when clicking on the circleci-redirector app "check": https://output.circle-artifacts.com/output/job/8ffc06e5-f762-4043-a1c8-7aca457d01e6/artifacts/0/_site/index.html

Yet when starting to navigate FROM that site (e.g., clicking on "News"), I get:

invalid build specification

And the browser shows the following link: https://output.circle-artifacts.com/0/_site/news.html

while the correct link is https://output.circle-artifacts.com/output/job/8ffc06e5-f762-4043-a1c8-7aca457d01e6/artifacts/0/_site/news.html (as I can see from the circleci artifacts tab)

Do you know what the issue is?

Never mind the screwed up CSS, I think that's a Jekyll issue that is orthogonal.

[larsoner]

Looking at the HTML source I see:

<a class="nav-link" href="/0/_site/specification.html">SPECIFICATION </a>

I would expect this to link to https://<DOMAIN>/0/_site/specification.html, which it does. So I don't think this is a redirector issue but rather a HTML source / link issue, where you assume that the output/links will not be nested under other directories, but they are.

CircleCI changed the way they make these urls a few months back. It always used to be https://<DOMAIN>/... where <DOMAIN> was a build-specific string like build234r976349578.artifacts.circleci.com or something. Now they've changed it so that the <DOMAIN> is always output.circle-artifacts.com, and the job-specificness comes later in the path in subfolders, e.g., https://<DOMAIN>/output/job/8ffc06e5-f762-4043-a1c8-7aca457d01e6/....

[larsoner]

... TL;DR: you probably need to change to relative links rather than absolute

[sappelhoff]

Thanks @larsoner that'll help with debugging!