Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI artifacts appear to be broken -- switch to netlify? #230

Closed
sappelhoff opened this issue Apr 9, 2022 · 2 comments · Fixed by #241
Closed

CircleCI artifacts appear to be broken -- switch to netlify? #230

sappelhoff opened this issue Apr 9, 2022 · 2 comments · Fixed by #241

Comments

@sappelhoff
Copy link
Member

see the CI checks, e.g.: https://output.circle-artifacts.com/output/job/66c07efe-69c5-4166-953b-378a98713e4a/artifacts/0/_site/index.html

the job/66c07efe-69c5-4166-953b-378a98713e4a seems to be the problem.

@sappelhoff
Copy link
Member Author

sappelhoff commented Jul 28, 2022

I think we should switch to deploy previews from netlify: https://docs.netlify.com/site-deploys/deploy-previews/

for two reasons:

  • no idea how to solve the circleci issue
  • that still wouldn't solve the fact that CSS isn't linked if no jekyll serve is called (this is different to static html deployed, e.g., via sphinx, where everything works without any active "serving")

see also:

@sappelhoff sappelhoff changed the title CircleCI artifacts appear to be broken CircleCI artifacts appear to be broken -- switch to netlify? Jul 28, 2022
@sappelhoff
Copy link
Member Author

This also seems like a nice solution: https://github.com/rossjrw/pr-preview-action

alas:

This Action does not currently support deploying previews for PRs from forks, but will do so in rossjrw/pr-preview-action#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant