[INFRA] downgrade github-changelog-generator to 1.14.3 due to issue with 1.15.2 #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to --since-tag issue. See: bids-standard#594 (comment) And investigation here: https://gitter.im/github-changelog-generator/chat?at=5f57456cec534f584fedf00d This param gets automatically set when using --base, because the "base" file gets parsed for versions. In our case, the latest version in "base" (pregh-changes.md) happens to be 1.1.1, and then --since-tag is automatically set to 1.1.1 and that tag cannot be found in the repository, because we never tagged such a version in git. Alternative options next to downgrading github-changelog-generator are (i) to make a PR against github-changelog-generator and add an option that allows explicitly setting --since-tag to None, or (ii) tagging the first commit of the bids-specification repository as 1.1.1, however the latter would be a weird hack.
sappelhoff
changed the title
bids-maintenance
added a commit
that referenced
this pull request
Sep 8, 2020
|
hooray, this has worked: c47e0ff and the now let's see for how long github-changelog-generator in version they seem to have a lack of maintainers for that project currently: github-changelog-generator/github-changelog-generator#727 |
|
@sappelhoff that's true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
--since-tagissue.This param gets automatically set when using
--base(which we do), because the "base" file gets parsed for versions.In our case, the latest version in "base" (pregh-changes.md) happens to be
1.1.1,and then
--since-tagis automatically set to1.1.1and that tagcannot be found in the repository, because we never tagged such a
version in git.
Alternative options next to downgrading github-changelog-generator
are:
an option that allows explicitly setting
--since-tagto None, oras
1.1.1, however the latter would be a weird hack.