Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: request addressbook for address lookups #597

Merged
merged 2 commits into from
Jun 11, 2024
Merged

feat: request addressbook for address lookups #597

merged 2 commits into from
Jun 11, 2024

Conversation

schmanu
Copy link
Collaborator

@schmanu schmanu commented Jun 9, 2024 •
edited
Loading

Resolved #3

What this PR changes

  • Requests addressbook permissions when the app loads
  • If granted, stores the addressbook in the redux state
  • Uses addressbook when looking up addresses. Addressbook names have a higher priority than ENS names and will be preferred.

Other changes

  • Fixes bug when loading collectible balances which caused a re-render loop
  • Adds yarn task to easily bump all safe-apps-sdk packages to the latest version.

@schmanu schmanu requested a review from bh2smith June 9, 2024 17:14
@schmanu schmanu mentioned this pull request Jun 9, 2024
Closed
bh2smith
bh2smith approved these changes Jun 9, 2024
View reviewed changes
Copy link
Owner

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although I haven't yet tried it out. Will try a bit later today.

@schmanu schmanu merged commit 1757c5e into main Jun 11, 2024
2 checks passed
@schmanu schmanu deleted the addressbook branch June 11, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bh2smith bh2smith bh2smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch and display Receiver accounts by name
2 participants
@schmanu @bh2smith