cancel event does not fired when copy: true #685
Conversation
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "dragula", | |||
| "version": "3.7.3", | |||
| "name": "dragula-fixed", | |||
There was a problem hiding this comment.
This attribute should not change
| "name": "dragula-fixed", | |
| "name": "dragula", |
dragula.js
Outdated
| function getParent (el) { | ||
| if (el) { | ||
| return el.parentNode === doc ? null : el.parentNode; | ||
| } else { | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this would be easier to maintain
| function getParent (el) { | |
| if (el) { | |
| return el.parentNode === doc ? null : el.parentNode; | |
| } else { | |
| return null; | |
| } | |
| } | |
| function getParent (el) { return el && el.parentNode !== doc ? el.parentNode : null; } | |
| } |
|
thank you @toofff , but now to use the fix we need that someone with write access publish this new version. How we can speed that? |
|
@ignaciostellino You have to see with @LeaVerou ;) |
|
Sorry folks, I reached out to @bevacqua to be added as a maintainer during a period I had a lot of time for Dragula and had started a v2 rewrite, but by the time I was actually added, I was too swamped with other things and didn’t have time anymore. At this point, I don't know if I ever will. @bevacqua feel free to remove me if that makes more sense. |
[BUG] Fix cancel revert with copy and copySortSource
|
For my part, I have a version that fixes a lot of things (it takes over the fixes from certain PRs or issues and part of the work of @LeaVerou) and can be an implementation with typescript, if I manage to plan some time for myself. end of the month. Maybe following his modifications I could see with @bevacqua to continue to maintain his project? |
@toofff that will be great if we can benefit from the fixes of the comunity and have a new version available :) |
Fix for #680 and #684