fix: allow calling release without argument #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `release({})` used to be okay. The code of `release` would try
to grab `clientX/Y` from the empty object, get `undefined` for both
coordinate, and feed them to `elementFromPoint`. `elementFromPoint`
was fine with that and just returned `null`. However a recent Chrome
change broke this. Chrome now checks that the coordinates passed to
`elementFromPoint` are finite doubles and so passing `undefined` no
longer works.
This commit makes it so that calling release without an event object
works. It will just skip trying to find a drop target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
release({})used to be okay. The code ofreleasewould try to grabclientX/Yfrom the empty object, getundefinedfor both coordinate, and feed them toelementFromPoint.elementFromPointwas fine with that and just returnednull. However a recent Chrome change broke this. Chrome now checks that the coordinates passed toelementFromPointare finite doubles and so passingundefinedno longer works.This commit makes it so that calling release without an event object works. It will just skip trying to find a drop target.
As I was submitting this PR, I noticed another PR for the same issue. However, I disagree with the solution provided there. Calling
releasewithclientXandclientYarbitrarily set to -1 is not safe as the coordinates-1, -1can be pointing to a legitimate element for some use-case scenarios. Rare? Yes, but it can happen.