Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not check for default scopes #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

morr
Copy link

@morr morr commented Sep 24, 2019

Do not pass ::Doorkeeper.configuration.default_scopes in token.acceptable?.

This logic is completely broken when ::Doorkeeper.configuration.default_scopes != [].
default_scopes are scopes that applied to the token when application owner did not provide any desired scopes.
But when application DID provide desired scopes, then these scopes could not match with default_scopes and thus authentication fails.

And one more thing. devise-doorkeeper should not check scopes anyway because scopes are checked on controller level via doorkeeper_authorize! :scope_name directive.

Do not pass `::Doorkeeper.configuration.default_scopes` in `token.acceptable?`. This logic is completely broken when `::Doorkeeper.configuration.default_scopes != []`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant