Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not pass
::Doorkeeper.configuration.default_scopes
intoken.acceptable?
.This logic is completely broken when
::Doorkeeper.configuration.default_scopes != []
.default_scopes
are scopes that applied to the token when application owner did not provide any desired scopes.But when application DID provide desired scopes, then these scopes could not match with
default_scopes
and thus authentication fails.And one more thing.
devise-doorkeeper
should not check scopes anyway because scopes are checked on controller level viadoorkeeper_authorize! :scope_name
directive.