Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zone-Transfer as Env-Option / Dockerfile correction / docker build . works again / glibc was missing / updated golang image #37

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DuckY1987
Copy link

Zone-Transfer as Env-Option / Dockerfile directory correction / docker build . works again / glibc was missing / updated golang image

@almereyda
Copy link

From quickly looking at the PR, I would like to suggest some changes that are of contribution and cosmetic nature:

  • It seems this PR is largely oriented on fixing the build environment. Was there a specific regression around the 1.20 Go version, the missing libc6 and the paths in the COPY directives, which led you to the changes?
  • As it will be mandatory to configure the new feature after merge, does it appear useful to add an explanation to the README, on how it is being used?
  • Your PR introduces new indentation rules. It seems rather advisable to format the document according to the style of the original source, rather than providing a new default. It is also not easy to depict from the diffs, which lines where actually changed, and which were just reformatted.

Optionally supporting AXFR in this setup seems like a useful addition, why I have provided some comments as seen from here, but I do not know if this repository is maintained anymore.

Also the ISC upstream documentation of BIND mentions some more configuration variables, of which some suggest to be useful for fine-tuning AXFRs.

@DuckY1987
Copy link
Author

DuckY1987 commented Nov 18, 2023

@almereyda it looks like the repo is not maintained anymore, unfortunately.

to answer your questions:

yes i had to overwork the build environment, otherwise docker build would have failed, it was because of the libc6, the path's have been just replaced out of cosmetical and practiable reasons, that you can just clone the repo and if its necessary, that you can use docker build flowless.

I saw it as fastest solution, as it was to be honest, my first commit ;).

The neater solution would be, of course to integrate the AXFR and fine tunings in the dashboard.

For the README:

You simply need to include another parameter to the docker run command: -e DDNS_TRANSFER=x.x.x.x

When you deploy the container.

Concerning the new indentation rules, i commit my change via github web and copied them from the windows terminal which was connected via SSH to my server, so i'm not sure if its because of that.
I just changed a couple of lines.

The only change i made in the setup.sh was:

allow-transfer { ${DDNS_TRANSFER}; };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants