Add captured frames to EnhancedStackTrace #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... test are not running. Let me look into that |
|
I always assume those frames were "hidden" by design: |
|
It looks to me like they're not correctly parsed yet. I can include the code to the stacktrace tomorrow. |
|
The code is here: https://gist.github.com/marwie/84efcd6a6a22f24208bba7abae13299b |
|
@benaadams Any thoughts on merging this or other recent pr's? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injecting captured stackframes into EnhancedStackTrace
Example without injection in Unity context:
Before
After
Example using sample in Unity context:
Before:
After:
