Fixes Winforms Progressbar #2485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks for the PR. It's currently failing CI because it's missing a changenote. It's also unclear if this will impact on tests - it feels like there should be an impact on tests.
|
FYI - you can ignore the test failures on Python 3.13 - there's been a regression in Freezegun that is incompatible with Python 3.13.0a6; the fix has been made upstream, but we're waiting on an updated release. However, the test failure on iOS does need to be resolved. You'll need to investigate why that test is failing and work around the issue, or find a way to make the test skip on iOS. |
|
A fix for the Python 3.13 issue can be found in #2498. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2430
PR Checklist: