Refactor Candidate class in fetchart.py to improve resizing logic #5152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5151
keep resizing until all validations have passed.
Candidate._validate
gives priority to reformatting before downsizing since in case of PNG it downsizes by converting to JPEG and if still does not match the size requirements it still remains to perform since first performing downsizing does nothing and is later skipped to avoid getting stuck in an infinite loop.To Do
docs/
to describe it.)docs/changelog.rst
to the bottom of one of the lists near the top of the document.)