An opinionated fix for "the albumtype(s) problem" #5075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses parts of #4715
This fix is of the type "works for me" and I'd like to open the discussion and test for others. In my opinion most of the problems we have with
albumtypes
andalbumtype
fighting against each other is because it just does not make sense to save both of them in beets. No matter where the real problem is, in the end it should be sufficient to save the data once in the beets library, hence only in the multifieldalbumtypes
. I'm proposing to kick outalbumtype
from beets entirely!This fix does not require any changes to mediafile
Furthermore this fixes saving
albumtypes
for the Discogs, the Spotify and the Deezer plugin. Previously populatingalbumtype
was implemented theoratically but broken, andalbumtypes
was not implemented. (I only recently realized this while working on this fix, please tell me if there is open issue for that already, so I can attach them to this PR, thanks!)A nice side effect of the latter fix is that files that where tagged using one of those plugins, can finally be used correctly by the albumtypes plugin as well 馃帀
To Do
albumtypes
instead ofalbumtype