strncasecmp function fix #232
Conversation
strncasecmp does not work correctly, so unit tests fail
formatting fix
Added the FluidConsole project. The project is a win32 console application that allows you to debug and emulate Fluidnc code on Windows.
|
Whoa you just saved me a lot of work, because this was exactly the intention of how I started this x86 support branch (and I didn't knew that you can use conio like this)! I'm actually surprised that it works with candle with just these changes. I did an extensive review, and nagged about the things that I could find. One thing that is a bit of an issue, is that you targetted the 'main' branch instead of the 'devt' branch in the PR (which means we cannot take it as-is without breaking git), but tbh I don't think it will be a lot of trouble cherry-picking the code and re-target it. I would very much like to have these remaining things fixed so we can get this in the main branch. If you have any questions or remarks, feel free to do so, or just join us on Discord. |
|
great that you liked my work ) |
function strncasecmp does not work correctly, so unit tests fail