Update the Date data set to avoid DST transition windows#366

Open

logiclrd wants to merge 8 commits intobchavez:masterfrom logiclrd:JDG_DateTimeAvoidDSTTransition

+499-41

Commits on Apr 21, 2023

Added unit test DateTest.will_not_generate_values_that_do_not_exist_due_to_daylight_savings that detects the error when run in a time zone with DST transitions.

logiclrd
authored and
bchavez
committed
Added tests will_adjust_start_time_to_avoid_dst_transition and will_adjust_end_time_to_avoid_dst_transition to DateTest.cs.

logiclrd
authored and
bchavez
committed
Added unit tests to DateTest.cs exercising the edge cases where the start/end times are exactly equal to the daylight savings time transition window start/end

logiclrd
authored and
bchavez
committed
Added test DateTest.works_when_start_time_is_invalid_due_to_DST_change_window based on feedback from @bchavez . Updated the CalculateTransitionDateTime helper to specifically mark the DateTimes it r…

logiclrd
authored and
bchavez
committed
Improved the semantic correctness of XML documentation of the Date.Between method.

logiclrd
authored and
bchavez
committed
Updated Recent and RecentOffset to avoid multiple consecutive calls to SystemClock, because in extremely rare cases, these could return different values, potentially not even in-order.

logiclrd
authored and
bchavez
committed
Made reference to a variable name in a test failure message dynamically linked to the actual variable using nameof().

logiclrd
authored and
bchavez
committed
Placed all assert blocks in DateTest.cs into AssertionScopes.

logiclrd
authored and
bchavez
committed