-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applied black formatting #55
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewasheridan
commented
Nov 30, 2019
Comment on lines
-7
to
-8
long_description="Extensive support for Python list prompts \ | ||
formatting and colors", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually removed the \
and made this a single line string manually. This was the only change that I made manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bullet Pull Request
Summary
Implements code formatting through the use of the Python code formatter black
Motivation
Reading and working on code that uses a standard formatting is easier.
This PR should satisfy Issue #17
Implementation
black -l 120 <filename>
and committedWhy use
black
?black
follows a strict subset of PEP8 and it is easy to use.What really did
black
do here?The biggest changes:
'
become double-quotes"
How do we use and install
black
?to install:
pip install black
to use:
black -l 120 <filename>
What is
-l 120
?By passing in the argument
-l 120
to black we are telling it to use a 120 length line limit. The default for black is 88 characters, I have found 120 to be more readable.Is there a way to apply
black
automatically before a commit?Yes! We can use a pre-commit hook. There are many ways to set a formatter like black as part of a pre-commit hook. I did not want to include that in this PR because I felt that it was outside the scope of the PR.
I like to use
pre-commit
for pre-commit hooks. The instructions at their site are adequate, but I would be happy to set them up for this great project.You could also manually create pre-commit hooks, or add black to your favorite IDE. Black integrates nicely to PyCharm, Sublime, and VSCode.
Note: I have no affiliation with
black
orpre-commit
or anything else. Likebullet
, I think they are great projects.DCO 1.1 Signed-off-by: Andrew A Sheridan [email protected]