feature/DEVSU-2543-auto-image-sizing #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #414 +/- ##
===========================================
- Coverage 76.96% 76.96% -0.01%
===========================================
Files 179 179
Lines 6038 6033 -5
Branches 696 696
===========================================
- Hits 4647 4643 -4
+ Misses 1314 1313 -1
Partials 77 77 ☔ View full report in Codecov by Sentry. |
elewis2
requested changes
Jan 8, 2025
| @@ -57,4 +37,6 @@ module.exports = { | |||
| MASTER_REPORT_ACCESS: ['admin', 'manager'], | |||
| ALL_PROJECTS_ACCESS: ['admin', 'all projects access'], | |||
| UPDATE_METHODS: ['POST', 'PUT', 'DELETE'], | |||
| IMAGE_UPLOAD_LIMIT: 3000000, | |||
There was a problem hiding this comment.
would it be possible to make these valuables configurable at runtime, with this as the default?
|
|
||
| const result = await db.query( | ||
| `SELECT | ||
| SUM(pg_column_size("reports_image_data")) AS avg_size_bytes |
There was a problem hiding this comment.
minor: maybe call this total_bytes
| // Process the image (resize and format) and update the size | ||
| const resizedImage = await sharp(image.data) | ||
| .resize( | ||
| Math.floor(image.info.width / 1.5), |
There was a problem hiding this comment.
could we also make the 1.5 configurable?
| @@ -72,8 +72,6 @@ router.route('/:template([A-z0-9-]{36})') | |||
| data: logo.data, | |||
| filename: logo.name, | |||
| format: logo.mimetype, | |||
There was a problem hiding this comment.
I think the frontend might need the logo and header to have a specific height and width, @kttkjl can you confirm/deny?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features: