-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DoubleCross]ハプニングチャートとRWプロローグチャートを振るためのコマンド(HC, PCP, PCN)を追加 #736
Open
RYOSKATE
wants to merge
13
commits into
bcdice:master
Choose a base branch
from
RYOSKATE:doublecross_hc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RYOSKATE
changed the title
[DoubleCross]ハプニングチャートの振るためのコマンド(HC)を追加
[DoubleCross]ハプニングチャートを振るためのコマンド(HC)を追加
Aug 21, 2024
patchang86
reviewed
Dec 28, 2024
patchang86
reviewed
Dec 28, 2024
patchang86
reviewed
Dec 28, 2024
patchang86
reviewed
Dec 28, 2024
patchang86
reviewed
Dec 28, 2024
patchang86
reviewed
Dec 28, 2024
patchang86
reviewed
Dec 28, 2024
patchang86
suggested changes
Dec 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ついでにRWチャートも一気に入れてしまったらどうでしょうか?
feat: [DoubleCross]RWプロローグチャート追加(説明文) Co-authored-by: patchang86 <[email protected]>
feat: [DoubleCross]RWプロローグチャート追加(コマンド登録) Co-authored-by: patchang86 <[email protected]>
feat: [DoubleCross]RWプロローグチャート追加(コマンド実装) Co-authored-by: patchang86 <[email protected]>
feat: [DoubleCross]RWプロローグチャート追加(メッセージ) Co-authored-by: patchang86 <[email protected]>
feat: [DoubleCross]RWプロローグチャート追加(コマンド分岐) Co-authored-by: patchang86 <[email protected]>
feat: [DoubleCross]RWプロローグチャート追加(コマンド実装) Co-authored-by: patchang86 <[email protected]>
feat: [DoubleCross]RWプロローグチャート追加 Co-authored-by: patchang86 <[email protected]>
@patchang86 ありがとうございます。実装もほとんどいただいていたため、suggestion commitし、少し修正とテストまで追加いたしました。改めてご確認よろしくお願いいたします。 |
RYOSKATE
changed the title
[DoubleCross]ハプニングチャートを振るためのコマンド(HC)を追加
[DoubleCross]ハプニングチャートとRWプロローグチャートを振るためのコマンド(HC, PCP, PCN)を追加
Dec 28, 2024
あ!迷惑じゃなかったら幸いです。 Githubが苦手でインデントとかで大変お手数をおかけしました。 テストまでありがとうございました! これで次のバージョンで一緒にアップデートされるといいですね~ |
patchang86
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
『DoubleCorss』に、フォーカスシステム(FS)判定のハプニングチャート用のコマンドが欲しく実装を試みました。