Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotnet sln project type #1915

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented Oct 29, 2024


The presence of an "src/" directory doesn't say anything about the
type of the project. This PR fixes the dotnet sln project type to rely
on the presence of an .sln file instead of the "src/" directory.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings => the code in master branch does
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

The presence of an "src/" directory doesn't say anything about the
type of the project. This commit fixes the dotnet sln project type to
rely on the presence of an .sln file instead of the "src/" directory.
@DamienCassou DamienCassou marked this pull request as ready for review October 29, 2024 16:56
@bbatsov bbatsov merged commit e898a50 into bbatsov:master Nov 1, 2024
5 of 7 checks passed
@bbatsov
Copy link
Owner

bbatsov commented Nov 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants