Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Support added for WebM MediaType #51

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Reda1000
Copy link

I have used this library a while ago and required video support + rendering in browser now. So i added this functionality through (re)start, finish and pause / resume buttons / functionality. It doesnt include audio.

I have used an additional dependency called whammy which just supports video/webm and image/webp-Frames so far. I tested manually and automatically by three additional scenarious that run successful:

  • start and finish
  • start, restart and finish
  • play, pause, resume and finish

User need to add whammy.js in angular.json for video support which seems a bit odd - i didnt figure out a nicer way.

Let me know how to improve code quality to meet your requirements.

Thanks for your work.

@Reda1000 Reda1000 mentioned this pull request Jun 20, 2019
@basst314
Copy link
Owner

Hi @Reda1000,

Thanks for raising this PR. I will look into it when I have some time.

@vikreinok
Copy link

It would be really cool if there would be audio as well.

What We are looking for is users capturing video with audio (very important) and submitting it.
Later, a REST service could provide the content for replay.

@Reda1000
Copy link
Author

Reda1000 commented Nov 19, 2019

@vikreinok you have similar task like i had. I prepared video support but had to use whammy - webm encoder - which breaks build. I only also was partially happy cause the encoded frame rate sometimes went "out of sync" - leading to faster or slower playback than normal.

In the end it fulfilled the tasks need so i did not tinker more on this solution - on implementation I made experience that most commonly a server is ised for doing the encoding instead of browser.

Maybe @basst314 could share his thoughts if video+audio encoding should be done at clientside? In this case I could try working out better solution + better build handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants