Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable utilization as module #35

Closed
wants to merge 2 commits into from

Conversation

abejenaru
Copy link

No description provided.

@bartTC
Copy link
Owner

bartTC commented Apr 8, 2024

Could you explain the reason behind this?

@abejenaru
Copy link
Author

Could you explain the reason behind this?

This allows to also run pip-check as a python module (e.g python -m pip_check), and doesn't break running it as a package.
I'm using python in a locked Windows environment, where running packages directly is restricted.

@bartTC
Copy link
Owner

bartTC commented Apr 9, 2024

I'll give it some more tests regarding the pypi build and merge soon.

@bartTC
Copy link
Owner

bartTC commented Apr 12, 2024

It doesn't look like the package itself is going to get build. You can test this by running tox.

py311: commands[1]> pip-check
Traceback (most recent call last):
  File "/private/tmp/tox/pip-check/py311/bin/pip-check", line 5, in <module>
    from pip_check import main
ImportError: cannot import name 'main' from 'pip_check' (/private/tmp/tox/pip-check/py311/lib/python3.11/site-packages/pip_check/__init__.py)
py311: exit 1 (0.16 seconds) /Users/martin/Workspace/pip-check> pip-check pid=32760

@abejenaru
Copy link
Author

Noted, I will run the full test suite

@bartTC
Copy link
Owner

bartTC commented Aug 18, 2024

Closing this due to staleness.

@bartTC bartTC closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants