Allow values to be trimmed before checking #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "hasHeaderRow" into the sample and change "isUnique" to "unique" (according to ColumnValidatorConfiguration.cs.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both NotNullableValidator and TextFormatValidator cannot prevent values containing only whitespace. Even though IsRequired is set, the former validator uses IsNullOrEmpty, which means whitespace is allowed. I tried to use Pattern instead, only to realize the latter validator will not execute the regular expression unless the value to be checked is not null or whitespace. To avoiding making a change that would affect the current users, I've added the ability to trim data before doing a validation.