-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better dev docker containers, Simpler production docker file, caddy for ssl #136
base: main
Are you sure you want to change the base?
Conversation
I've merged this into my fork and have been using the new Makefile as part of my development flow for a week now. It's been a much smoother experience. Thanks for putting this together. Any idea how to get automatic reloads working for the react frontend? |
I see this PR makes for a much better development experience. I also want to make sure it won't impact existing deployments. This is probably an issue with my environment that I need to work through. When I re-deploy with the newly built container I get the following error: I also noticed the switch to build for arm64 was removed. This was for multiarch containers allowing deployment to a higher powered RaspberryPi. Perhaps this is covered by the CGO_ENABLED switch, but I want to make sure this use case is still supported. I appreciate these changes and will merge them in once I can properly test them. Thank you! |
sounds like you don't have go/bin in your PATH env |
I'll take a look to re-add that, I did try earlier but cross compilation wasn't working from my m2 MacBook, maybe my fedora pc will give better results. |
@mbaum0 Last time I attepted this I got very stuck as the api wasn't prefixed with I'll take another look after v3 is there |
RUN if [ "$TARGETPLATFORM" = "linux/amd64" ]; then ARCHITECTURE=amd64; elif [ "$TARGETPLATFORM" = "linux/arm64" ]; then ARCHITECTURE=arm64; elif [ "$TARGETPLATFORM" = "linux/arm64" ]; then ARCHITECTURE=aarch64; else ARCHITECTURE=unsupported; fi \ If you're talking about the above command. I'll be adding something like this soon, I noticed building a go binary without explicitly saying which arch it should cross build to just doesn't work well.
|
make dev-restart-server
I tried to keep the changes scoped to just docker.
make dev-start
docker