Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test for mysql populating with limit incorrectly. #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add failing test for mysql populating with limit incorrectly. #83

wants to merge 1 commit into from

Conversation

devinivy
Copy link
Contributor

@devinivy devinivy commented Jul 8, 2015

See issue over at balderdashy/waterline-sequel#53.

@devinivy devinivy mentioned this pull request Jul 8, 2015
Closed
@dmarcelino
Copy link
Member

I agree with the test, that should definitely pass: 👍

@jelhan
Copy link

jelhan commented Mar 11, 2016

What happened to this PR? While working on a performance improvement at https://github.com/balderdashy/sails-mysql/issues/291 I noticed that limit, sort and skip options for populate() aren't covered by tests. This is not covering all use cases but it's a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devinivy @dmarcelino @jelhan