Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Use an allowlist for all JS includes #7210

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Mar 9, 2023

  1. Use BASIC_SUPPORTED_FILE_EXTENSIONS for all JS includes

    An exclusion list does not make much sense here - trying to include
    literally any file other than markdown and txt files - including
    dotfiles - results in errors lifting if there are things like editor
    temp files, .gitignore, and so on.
    
    An inclusion list makes more sense here, and we have one already that
    we're using elsewhere, so go ahead and just use it any time we're
    including source files.
    cincodenada authored and Ell Bradshaw committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    4858341 View commit details
    Browse the repository at this point in the history
  2. Add some sample files that should be ignored to the sample app

    This crashes out the tests, which accomplishes testing this
    cincodenada authored and Ell Bradshaw committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    65e217e View commit details
    Browse the repository at this point in the history
  3. Add line to changelog

    The guidelines said to add it under master which wasn't there, so I
    added it
    cincodenada authored and Ell Bradshaw committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    4ab8748 View commit details
    Browse the repository at this point in the history
  4. Add ejs to supported extensions

    This broke loading views otherwise
    Ell Bradshaw committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9253abc View commit details
    Browse the repository at this point in the history