Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed socket.io-client v4 not being able to obtain options from sails #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serjrd
Copy link

@serjrd serjrd commented Feb 20, 2024

socket.io-client v4 uses _opts = Object.assign({}, opts), hence it cannot obtain options from sails.io.js that were defined using getters/setters through Object.defineProperty without explicitly marking those properties as enumerable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant