Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pop context changes #1182

Open
wants to merge 10 commits into
base: demo-pop-context
Choose a base branch
from
Open

Pop context changes #1182

wants to merge 10 commits into from

Commits on Dec 4, 2023

  1. add filter support to contexts 

    Also fixes a bug with PopContext but I really don't wanna make it two commits
    @dkmk100
    dkmk100 committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    29d5bdd View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. context manipulator rework 

    Added support for filters, and added validation and stuff

The else and example filter glyphs are only there for showcase purposes and can be removed in the final PR
    @dkmk100
    dkmk100 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    39a6a2b View commit details
    Browse the repository at this point in the history

  2. fix validator bugs and run datagen

    @dkmk100
    dkmk100 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    701df7e View commit details
    Browse the repository at this point in the history

  3. add placeholder art for easier testing

    @dkmk100
    dkmk100 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    7e8d2ec View commit details
    Browse the repository at this point in the history

  4. make IContextManipulator#CanEscape return a boolean

    @dkmk100
    dkmk100 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    6b38b28 View commit details
    Browse the repository at this point in the history

  5. fix nested context creators 

    SpellContext#pop wasn't keeping track of context creators inside the context correctly.
Also moved the set keeping track of context creators to the API as it's needed by spell context.
    @dkmk100
    dkmk100 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a5693bd View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Move filter and cancel logic to callbacks

    @baileyholl
    baileyholl committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    37f2dff View commit details
    Browse the repository at this point in the history

  2. temp disable validator

    @baileyholl
    baileyholl committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    f5d11e3 View commit details
    Browse the repository at this point in the history

  3. Revert "temp disable validator" 

    This reverts commit f5d11e3.
    @baileyholl
    baileyholl committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    290d8b8 View commit details
    Browse the repository at this point in the history

  4. Revert "Move filter and cancel logic to callbacks" 

    This reverts commit 37f2dff.
    @baileyholl
    baileyholl committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    54669ad View commit details
    Browse the repository at this point in the history