-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pop context changes #1182
Open
dkmk100
wants to merge
10
commits into
baileyholl:demo-pop-context
Choose a base branch
from
dkmk100:pop-context
base: demo-pop-context
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pop context changes #1182
Commits on Dec 4, 2023
-
add filter support to contexts
Also fixes a bug with PopContext but I really don't wanna make it two commits
Configuration menu - View commit details
-
Copy full SHA for 29d5bdd - Browse repository at this point
Copy the full SHA 29d5bddView commit details
Commits on Dec 7, 2023
-
Added support for filters, and added validation and stuff The else and example filter glyphs are only there for showcase purposes and can be removed in the final PR
Configuration menu - View commit details
-
Copy full SHA for 39a6a2b - Browse repository at this point
Copy the full SHA 39a6a2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 701df7e - Browse repository at this point
Copy the full SHA 701df7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e8d2ec - Browse repository at this point
Copy the full SHA 7e8d2ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b38b28 - Browse repository at this point
Copy the full SHA 6b38b28View commit details -
SpellContext#pop wasn't keeping track of context creators inside the context correctly. Also moved the set keeping track of context creators to the API as it's needed by spell context.
Configuration menu - View commit details
-
Copy full SHA for a5693bd - Browse repository at this point
Copy the full SHA a5693bdView commit details
Commits on Dec 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37f2dff - Browse repository at this point
Copy the full SHA 37f2dffView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5d11e3 - Browse repository at this point
Copy the full SHA f5d11e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 290d8b8 - Browse repository at this point
Copy the full SHA 290d8b8View commit details -
Revert "Move filter and cancel logic to callbacks"
This reverts commit 37f2dff.
Configuration menu - View commit details
-
Copy full SHA for 54669ad - Browse repository at this point
Copy the full SHA 54669adView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.