Context Escape #1081
Open
Context Escape #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileyholl
reviewed
Aug 25, 2023
src/main/java/com/hollingsworth/arsnouveau/api/source/AbstractSourceMachine.java
Outdated
Show resolved
Hide resolved
baileyholl
reviewed
Aug 25, 2023
src/main/java/com/hollingsworth/arsnouveau/setup/registry/APIRegistry.java
Outdated
Show resolved
Hide resolved
removed unnecessary import and moved registry to the WIP registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all the interfaces and spell context changes required to add context escape.
The test filter effect is just for testing purposes and I fully expect it to be deleted before the PR is accepted (or at least before release).
Ideally I'd like the else and escape context glyphs to make it into the main mod, but I fully understand if including the else glyph doesn't really fit since there are no filters in base ars.
It would make sense to include escape context in the mod since it goes well with the glyphs already present. The PR still mostly achieves it's purpose without that, as addons creating duplicate escape context glyphs would be very minor.
All the API changes (and to a lesser extent the validator) are essential to getting the idea to work well, to be usable by addons, and to ensure the implementation can be improved in the future.