Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate examples to openApi part 14; affects [azuredevops discord netlify opencollective pub ros visualstudio] #9560

Merged
merged 4 commits into from Dec 4, 2023
Merged

migrate examples to openApi part 14; affects [azuredevops discord netlify opencollective pub ros visualstudio] #9560

merged 4 commits into from Dec 4, 2023

Conversation

chris48s
Copy link
Member

Refs #9285

The tokei tests are known to be failing #7569 so I've excluded them form the list of service tests to run. For now, lets just abstract that and refactor it anyway

@chris48s chris48s added service-badge Accepted and actionable changes, features, and bugs documentation Developer and end-user documentation labels Sep 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2023 •
edited

Warnings
⚠️ This PR modified service code for azure-devops but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for discord but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for netlify but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for opencollective but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for pub but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for ros but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for tokei but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for visual-studio-app-center but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against e318a7a

PyvesB
PyvesB approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

@chris48s chris48s added this pull request to the merge queue Dec 4, 2023
Merged via the queue into badges:master with commit 3eb4959 Dec 4, 2023
22 checks passed
@chris48s chris48s deleted the 9285-part14 branch December 4, 2023 13:15
Lordfirespeed pushed a commit to Lordfirespeed/shields that referenced this pull request Dec 18, 2023
@chris48s @Lordfirespeed
migrate examples to openApi part 14; affects [azuredevops discord net…
4273c3e 
…lify opencollective pub ros visualstudio] (badges#9560)

* migrate some services from examples to openApi

* migrate pub version

* improve pub descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
documentation Developer and end-user documentation service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris48s @PyvesB