-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Snyk vulnerability SNYK-JS-ZOD-5925617 by upgrading zod packages to latest #21800
Conversation
Changed Packages
|
Thanks for the contribution! |
Didn't squash my commits or sign them all. Will fix. |
2a85c11
to
49c9d7c
Compare
…es to latest Signed-off-by: Joseph Campos <[email protected]>
…es to latest Signed-off-by: Joseph Campos <[email protected]>
49c9d7c
to
0cbb03b
Compare
Signed-off-by: Joseph Campos <[email protected]>
Uffizzi Cluster |
Test case failing on depends. emotion may need to lock/rollback versions on csstype for now? frenic/csstype#189 |
This doesn't fix the problem right? The lockfile doesn't remove any vulnerable resolutions. |
To be clear, I don't mind this fix - but just noting that we already resolved to a fixed version (it was already in-range of the previous range as well), and so could anyone adopting Backstage too. However we also have a transitive dep on So I'm wondering if the actual fix is to remove the dependency on that plugin, or contact their author to see if they can address it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this since it still moves us somewhat forward, but let's also consider the other zod depencency branch that lingers behind as per the above
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Will this PR fix this issue? |
No, that's unrelated. |
Hey, I just made a Pull Request!
Addressing SNYK-JS-ZOD-5925617 by upgrading zod to latest in packages found with depends. Relied on yarn why for depends list. Will resolve issue #21777
ref:
https://security.snyk.io/vuln/SNYK-JS-ZOD-5925617
#21777
✔️ Checklist
Signed-off-by
line in the message. (more info)