Remove deprecated stuff #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,25 +75,15 @@ | |||
| * @param {Object} params Data should be sent to the method. | |||
| * @param {Object} [execOptions] Exec-specific options. | |||
| * @param {Boolean} [execOptions.enableBatching=true] Should the current call of the method be batched. | |||
| * @param {Boolean} [execOptions.noBatching=false] @deprecated Should the current call of the | |||
| * method be batched. | |||
There was a problem hiding this comment.
Let's remove this line, it's a part of the description above.
|
👍 |
| noBatching: !isArray(options.noBatching) && Boolean(options.noBatching) | ||
| enableBatching: options.hasOwnProperty('enableBatching') ? | ||
| options.enableBatching : | ||
| true |
There was a problem hiding this comment.
It would be good to add a comment that batching is enabled by default and that's why we have a boolean literal here.
|
Purification 👍 |
tarmolov
force-pushed
the
hevil.deprecated
branch
from
0b347a5 to
94f68d2
Compare
tarmolov
force-pushed
the
hevil.deprecated
branch
from
94f68d2 to
16afcb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.