Custom validators for methods #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, in general. Just a couple of notes:
|
Closed
tarmolov
force-pushed
the
hevil.validator
branch
from
04df378 to
b1f75d4
Compare
| * @param {String} [declaration.name] Parameter name. | ||
| * @param {String} [declaration.description] Parameter description. | ||
| * @param {String} [declaration.type] Parameter type. | ||
| * @param {Boolean} [declaration.required] Should the parameter be made obligatory. | ||
| * @returns {*} | ||
| * @throws HTTP error |
tarmolov
force-pushed
the
hevil.validator
branch
from
b1f75d4 to
cc2fb1c
Compare
| param1: {type: 'String'} | ||
| }, | ||
| options: { | ||
| paramsValidation: function (paramValue, paramType, paramName) { |
tarmolov
force-pushed
the
hevil.validator
branch
from
c17f797 to
d38d14a
Compare
tarmolov
force-pushed
the
hevil.validator
branch
from
d38d14a to
98b93d2
Compare
|
Any suggestions? Merge? |
|
Almost LGTM. The pipe is still unescaped :)) |
|
GH shows a bad diff. It'is escaped. |
|
There are two of them. |
|
🤘 |
tarmolov
force-pushed
the
hevil.validator
branch
from
98b93d2 to
edd9dfd
Compare
|
OMG :) |
tarmolov
added a commit
that referenced
this pull request
Nov 28, 2014
Custom validators for methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to keep current normalize system, @twoRoger wants a stricter system (#79).
Let's think about validator mechanism in the library.
Default validation mode is
normalize(current way to preprocess parameters). We can add an extra one —strict, for instance. Also a developer has a chance to declare just a custom function for this issue.This option should be declared to each API method.
Opinions? Cons/pros?