Support urlencoded for all methods #77 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @returns {Object} | ||
| */ | ||
| function parseJson(value, type) { | ||
| return typeof value === 'string' && ['array', 'object'].indexOf(type) !== -1 ? |
There was a problem hiding this comment.
parseJson is never called with other types, why do you need this check here?
Seems that type parameter is not needed at all.
There was a problem hiding this comment.
Not all folks pass arrays and objects in string representation.
JSON.parse([1,2]); // Uncaught SyntaxError: Unexpected token ,There was a problem hiding this comment.
I mean, typeof value === 'string' ? is enough
tarmolov
force-pushed
the
hevil.urlencoded
branch
from
50cb618 to
5174af6
Compare
|
I don't like the idea of treating |
| */ | ||
| function parseJson(value) { | ||
| return typeof value === 'string' ? | ||
| JSON.parse(value) : |
There was a problem hiding this comment.
Let's add try-catch here and throw some human-friendly error instead of SyntaxError)
|
🤘 |
|
🆗 |
|
👍 |
tarmolov
added a commit
that referenced
this pull request
Nov 21, 2014
Support urlencoded for all methods #77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.