Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn developer if body-parse isn't executed #55

Merged
merged 2 commits into from
Nov 1, 2014
Merged

Conversation

tarmolov
Copy link
Member

Our middleware has a dependency from body-parser. I think it'd be great if we'll warn a developer about missed body-parser.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 045a6f8 on hevil.bodyparser into a21bb7b on master.

@watch-the-stars
Copy link

Ok)

@tarmolov
Copy link
Member Author

tarmolov commented Nov 1, 2014

Maybe you're right and we should throw an error not a warning.

Any opinions?

@watch-the-stars
Copy link

I'd say: be strict at development, but tolerant at runtime.
Still, if you like the idea of warning, I'm ok with it :)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7265b1f on hevil.bodyparser into a21bb7b on master.

@tarmolov
Copy link
Member Author

tarmolov commented Nov 1, 2014

Throwing an error looks better.

@watch-the-stars
Copy link

Cool 👍

tarmolov added a commit that referenced this pull request Nov 1, 2014
Warn developer if body-parse isn't executed
@tarmolov tarmolov merged commit 0305663 into master Nov 1, 2014
@tarmolov tarmolov deleted the hevil.bodyparser branch November 1, 2014 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants