Show exra information in validation error messages #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +40,11 @@ module.exports = function (value, name, declaration) { | |||
| case 'number': | |||
| var parsedValue = parseFloat(value); | |||
| if (Number.isNaN(parsedValue)) { | |||
| throw new ApiError(ApiError.BAD_REQUEST, 'invalid value for ' + name + ' parameter'); | |||
| var errorMessage = util.format( | |||
| 'invalid value for "%s" parameter, expected type "%s" but got "%d"', | |||
There was a problem hiding this comment.
Do you suggest using %s?
%d -> NaN
%s -> nan
There was a problem hiding this comment.
You used value, not parsedValue,
%s for value variable may be string or Object or undefined etc
%s for parsedValue always be NaN
tarmolov
force-pushed
the
error-information
branch
from
ba7dc35 to
cb42d6b
Compare
|
lgtm except copy-paste |
| @@ -39,7 +40,11 @@ module.exports = function (value, name, declaration) { | |||
| case 'number': | |||
| var parsedValue = parseFloat(value); | |||
| if (Number.isNaN(parsedValue)) { | |||
| throw new ApiError(ApiError.BAD_REQUEST, 'invalid value for ' + name + ' parameter'); | |||
| var errorMessage = util.format( | |||
| 'invalid value for "%s" parameter, expected type "%s" but got "NaN"', | |||
There was a problem hiding this comment.
but please keep value as well
tarmolov
force-pushed
the
error-information
branch
from
cb42d6b to
a063c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dfilatov @zloylos