Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel > babel 7.* #2033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

babel > babel 7.* #2033

wants to merge 1 commit into from

Conversation

smilingkite
Copy link

clarify that babel 7 (instead of babel in general) 'will stop lookup at package.json boundary ...'

clarify that babel 7 (instead of babel in general) 'will stop lookup at package.json boundary ...'
@netlify
Copy link

netlify bot commented May 22, 2019

Deploy preview for babel ready!

Built with commit f5e03ae

https://deploy-preview-2033--babel.netlify.com

@@ -22,7 +22,7 @@ This just means Babel _itself_ won't run on older versions of Node. It can still

For more info, read our [6.x vs 7.x comparison](config-files.md#6x-vs-7x-babelrc-loading).

Babel has had issues previously with handling `node_modules`, symlinks, and monorepos. We've made some changes to account for this: Babel will stop lookup at the `package.json` boundary instead of looking up the chain. For monorepo's we have added a new `babel.config.js` file that centralizes our config across all the packages (alternatively you could make a config per package). In 7.1, we've introduced a [`rootMode`](options.md#rootmode) option for further lookup if necessary.
Babel has had issues previously with handling `node_modules`, symlinks, and monorepos. We've made some changes to account for this: Babel 7.* will stop lookup at the `package.json` boundary instead of looking up the chain. For monorepo's we have added a new `babel.config.js` file that centralizes our config across all the packages (alternatively you could make a config per package). In 7.1, we've introduced a [`rootMode`](options.md#rootmode) option for further lookup if necessary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Babel has had issues previously with handling `node_modules`, symlinks, and monorepos. We've made some changes to account for this: Babel 7.* will stop lookup at the `package.json` boundary instead of looking up the chain. For monorepo's we have added a new `babel.config.js` file that centralizes our config across all the packages (alternatively you could make a config per package). In 7.1, we've introduced a [`rootMode`](options.md#rootmode) option for further lookup if necessary.
Babel has had issues previously with handling `node_modules`, symlinks, and monorepos. We've made some changes to account for this: Babel 7 will stop lookup at the `package.json` boundary instead of looking up the chain. For monorepo's we have added a new `babel.config.js` file that centralizes our config across all the packages (alternatively you could make a config per package). In 7.1, we've introduced a [`rootMode`](options.md#rootmode) option for further lookup if necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Babel has had issues previously with handling `node_modules`, symlinks, and monorepos. We've made some changes to account for this: Babel 7.* will stop lookup at the `package.json` boundary instead of looking up the chain. For monorepo's we have added a new `babel.config.js` file that centralizes our config across all the packages (alternatively you could make a config per package). In 7.1, we've introduced a [`rootMode`](options.md#rootmode) option for further lookup if necessary.
Babel has had issues previously with handling `node_modules`, symlinks, and monorepos. We've made some changes to account for this: Babel (since version 7) will stop lookup at the `package.json` boundary instead of looking up the chain. For monorepo's we have added a new `babel.config.js` file that centralizes our config across all the packages (alternatively you could make a config per package). In 7.1, we've introduced a [`rootMode`](options.md#rootmode) option for further lookup if necessary.

This will probably also be valid for other major Babel versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants