Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve async dispose fallback #16409

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Improve async dispose fallback #16409

wants to merge 10 commits into from
+113 −36

Commits on Apr 30, 2024

  1. fallback to sync dispose on undefined asyncDispose

    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    43eed64 View commit details
    Browse the repository at this point in the history

  2. fix: do not await the promise returned from a sync dipose

    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    61c830e View commit details
    Browse the repository at this point in the history

  3. improve asyncDispose error 

    Previously we throw "[Symbol.dispose] is not a function", which can be very confusing.
    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e57be3c View commit details
    Browse the repository at this point in the history

  4. optimize helper size

    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8fb2a72 View commit details
    Browse the repository at this point in the history

  5. simplify error message

    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    350dd2f View commit details
    Browse the repository at this point in the history

  6. update test cases

    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    947a930 View commit details
    Browse the repository at this point in the history

  7. Update packages/babel-helpers/src/helpers/usingCtx.ts 

    Co-authored-by: Nicolò Ribaudo <[email protected]>
    @JLHwung @nicolo-ribaudo
    JLHwung and nicolo-ribaudo committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c46ba2d View commit details
    Browse the repository at this point in the history

  8. tweak comment

    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    dcab815 View commit details
    Browse the repository at this point in the history

  9. rename enums

    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8869938 View commit details
    Browse the repository at this point in the history

  10. update fixtures

    @JLHwung
    JLHwung committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c3a7acf View commit details
    Browse the repository at this point in the history