Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset Error.prepareStackTrace finally #16187

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reset Error.prepareStackTrace finally #16187

wants to merge 2 commits into from

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? Fixes #16099
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? √
Documentation PR Link
Any Dependency Changes?
License MIT

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: core labels Dec 21, 2023
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 21, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56335

@liuxingbaoyu liuxingbaoyu marked this pull request as draft December 21, 2023 13:32
@liuxingbaoyu liuxingbaoyu marked this pull request as ready for review December 21, 2023 13:35
@liuxingbaoyu liuxingbaoyu changed the title Reset Error.prepareStackTrace on finally Reset Error.prepareStackTrace finally Dec 21, 2023
@liuxingbaoyu liuxingbaoyu mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
pkg: core PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Our custom Error.prepareStackTrace leaks to the user
3 participants
@liuxingbaoyu @babel-bot @JLHwung